Make Isolate take ownership of CreateParams #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
force-pushed
the
create_params
branch
from
d6c5df3
to
2b5d2ff
Compare
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Apr 20, 2020
piscisaureus
force-pushed
the
create_params
branch
from
2b5d2ff
to
cd0c098
Compare
piscisaureus
changed the title
piscisaureus
force-pushed
the
create_params
branch
from
cd0c098
to
05782b8
Compare
|
Not perfect, but landing it now b/c I need to get on with other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.