fix: remove use of deprecated apis #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
6d4bbec
to
561e372
Compare
mmastrac
reviewed
May 22, 2024
mmastrac
approved these changes
May 22, 2024
Another way is by calling a constructor created from a |
|
@0f-0b thanks for the pointer |
561e372
to
c053eba
Compare
5836af3
to
df8f589
Compare
df8f589
to
a770a1b
Compare
0f-0b
suggested changes
Jun 20, 2024
3081a5f
to
2a65ecb
Compare
2a65ecb
to
7813647
Compare
ry
reviewed
Jun 27, 2024
Comment on lines
+60
to
+65
| fn empty( | ||
| _scope: &mut v8::HandleScope, | ||
| _args: v8::FunctionCallbackArguments, | ||
| _rv: v8::ReturnValue, | ||
| ) { | ||
| } |
There was a problem hiding this comment.
Maybe increment a counter here to ensure it's called the correct number of times?
ry
reviewed
Jun 27, 2024
Comment on lines
-34
to
-35
| #pragma clang diagnostic ignored "-Wdeprecated-declarations" | ||
|
|
littledivy
reviewed
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1478
https://docs.google.com/document/d/1FWnrKxjl0P-jY0CMPlzbXkH8xkKoX6nM4e2OXq1EGHU
tldr some* v8 objects now directly store a "wrapped pointer" field which is traced by cppgc. cppgc no longer requires embedder field information when being set up, and this field is set using
Object::wrap/Object::unwrap.* objects must use the JSObjectWithEmbedderSlots map