Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Rust-side const ExternalOneByteStringResource subclass #1275

Merged
merged 15 commits into from
Jul 12, 2023
Merged

feat: Implement Rust-side const ExternalOneByteStringResource subclass #1275

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e472d5b
Rust-side OneByteConst VTABLE, const and very safe 'cause trust me, I…
aapoalas Jul 4, 2023
20ed043
Remove more uselessness
aapoalas Jul 10, 2023
305cbf6
Fix clippy
aapoalas Jul 10, 2023
8658c6a
x
aapoalas Jul 10, 2023
156609e
Try fix windows build
aapoalas Jul 10, 2023
db7adae
Merge branch 'main' into exp/external-const-one-byte-rust-side-vtable
aapoalas Jul 10, 2023
c07add1
Review comments
aapoalas Jul 11, 2023
d35607c
Merge branch 'exp/external-const-one-byte-rust-side-vtable' of github…
aapoalas Jul 11, 2023
b0616da
fix
aapoalas Jul 11, 2023
9e1185f
Reorder metadata fields, add more comments
aapoalas Jul 11, 2023
0ec92f5
More Windows specifics and comments
aapoalas Jul 11, 2023
8d8bd70
Merge branch 'main' into exp/external-const-one-byte-rust-side-vtable
aapoalas Jul 11, 2023
ef1c106
Revert accidental removal of repr(C)
aapoalas Jul 11, 2023
23818b3
Fix comment on MSVC RTTI Complete Object Locator pointer
aapoalas Jul 12, 2023
06479df
Add safety comment to 'impl Sync for OneByteConst'
aapoalas Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove more uselessness
  • Loading branch information
@aapoalas
aapoalas committed Jul 10, 2023
commit 20ed04386de41b352a8b5ae9b35dadf4d23389e9
4 changes: 2 additions & 2 deletions src/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,8 +1018,8 @@ class ExternalStaticOneByteStringResource
class ExternalConstOneByteStringResource
aapoalas marked this conversation as resolved.
Show resolved Hide resolved
: public v8::String::ExternalOneByteStringResource {
public:
ExternalConstOneByteStringResource(const char* data, int length)
: _data(data), _length(length) {
ExternalConstOneByteStringResource(int length)
: _length(length) {
static_assert(offsetof(ExternalConstOneByteStringResource, _length) == 16,
"ExternalConstOneByteStringResource's length was not at offset 16");
static_assert(sizeof(ExternalConstOneByteStringResource) == 24,
Expand Down