Add more Object methods #1240
Merged
Add more Object methods #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically Object::get_own_property_descriptor and Object::get_property_attributes
bartlomieju
reviewed
May 25, 2023
|
|
||
| /// Implements Object.getOwnPropertyDescriptor(O, P), see | ||
| /// https://tc39.es/ecma262/#sec-object.getownpropertydescriptor. | ||
| pub fn get_own_property_descriptor<'s>( |
There was a problem hiding this comment.
Any chance you could test a code path that returns None?
There was a problem hiding this comment.
V8 seems to never return an Empty MaybeLocal here. They also don't test this in their test_api.cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically Object::get_own_property_descriptor
and Object::get_property_attributes