feat: v8::Inspector::exception_thrown, v8::Inspector::create_stack_trace #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
added a commit
to denoland/deno
that referenced
this pull request
Dec 6, 2022
…#16943) Currently runtime exception are only displayed at the program end in terminal, which makes it only a partial fix, as a full fix requires denoland/rusty_v8#1149 which adds new bindings to the inspector that allows to notify it about thrown exceptions. This will be handled in a follow up commit.
piscisaureus
reviewed
Dec 6, 2022
| url: StringView, | ||
| line_number: u32, | ||
| column_number: u32, | ||
| stack_trace: UniquePtr<V8StackTrace>, |
There was a problem hiding this comment.
Is this argument optional?
If it is required, the type should be UniqueRef.
piscisaureus
reviewed
Dec 6, 2022
| pub fn create_stack_trace( | ||
| &mut self, | ||
| stack_trace: Local<StackTrace>, | ||
| ) -> UniquePtr<V8StackTrace> { |
There was a problem hiding this comment.
Does create_stack_trace() ever return nullptr?
If not, the return type should be UniqueRef.
There was a problem hiding this comment.
Yes, it does, we discussed this in #717 (comment)
piscisaureus
approved these changes
Dec 7, 2022
aapoalas
pushed a commit
to aapoalas/rusty_v8
that referenced
this pull request
Dec 22, 2022
…ace (denoland#1149) Adds APIs required to notify inspector about exceptions raised by the runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #717
Closes #715