Rolling to V8 10.9.194.1 #1118
Merged
Rolling to V8 10.9.194.1 #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
autoroll
branch
from
cedbd5e
to
5523d02
Compare
src/array_buffer.rs
Outdated
| #[inline(always)] | ||
| pub fn detach(&self) { | ||
| pub fn detach(&self, key: Local<Value>) -> Option<bool> { |
There was a problem hiding this comment.
This should probably be Option<Local<Value>>
There was a problem hiding this comment.
Care to elaborate? Do you want to default to passing undefined is the passed value is None?
There was a problem hiding this comment.
Although Rust's Option<Local> maps more closely to MaybeLocal, in the C++ API Local can be a null handle. The suggestion to replace the deprecated no-arguments Detach method is to call Detach with a null handle, so the Rust API should allow this as well.
github-actions
bot
force-pushed
the
autoroll
branch
from
3541b85
to
8c075eb
Compare
dsherret
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.