Remove libc dependency. #1117
Merged
Remove libc dependency. #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Use `std` functionality where possible. Only size_t needs to be defined like was done with the `intptr_t` type before. Also unifies the usage of `std::os::raw` types that where already defined in the support module.
|
I tried to reproduce the error that the CI throws, but can't reproduce it under x86_64-pc-windows-msvc nor x86_64-unknown-linux-gnu. It also seems to come from a function that was not changed by this PR. |
|
@piscisaureus please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to remove dependencies with functionality that is already present in the
stdor the crate.Only size_t needs to be defined like was done with the
intptr_ttype before.Also unifies the usage of
std::os::rawtypes that where already defined in the support module and used in other parts of the crate.