Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for V8 native function calls #1079

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Add benchmarks for V8 native function calls #1079

merged 1 commit into from
Sep 20, 2022

Conversation

littledivy
Copy link
Member 

> cargo bench -- function

19.1 ns per run 52.4 million ops/sec → new_
18.4 ns per run 54.2 million ops/sec → new_raw
14.4 ns per run 69.4 million ops/sec → new_set_uint32
6.7 ns per run 149.3 million ops/sec → new_raw_set_uint32
2.7 ns per run 369.0 million ops/sec → new_fast

ry
ry approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 6444cb9 into denoland:main Sep 20, 2022
ry added a commit that referenced this pull request Oct 5, 2022
@ry
Revert "Add benchmarks for V8 native function calls (#1079)"
df9ea2a 
This reverts commit 6444cb9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@littledivy @ry