Inline API functions #1078
Merged
Inline API functions #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this actually provide any benefit? I'd rather not litter the codebase with these declarations for a hypothetical improvement. |
ry
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
@littledivy I'm not sure I agree with this PR, but giving approval if you want to land and try it out with Deno in v0.51.0. I suspect this will not measurably improve anything - but we can try.
|
I don't have any benchmarks at the moment, and yes this likely won't be visible at all in Deno. It's just a strong hint for the compiler to inline the one-liner binding calls (that we have a lot of) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust is smart enough but no harm in being explict.