fix(fastcall): Fix options.data
representation
#1074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream CL: https://chromium-review.googlesource.com/c/v8/v8/+/3844662
Fast API calls invalidly used plain
v8::Value
for theoptions.data
representation. This effectively meant that only SMI data could successfully pass through to fast calls.The issue has now been fixed upstream, meaning that the
options.data
representation has becomev8::Local<v8::Value>
. This PR should then unblock downstream PR denoland/deno#15527