Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fastcall): Fix options.data representation #1074

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix(fastcall): Fix options.data representation #1074

merged 2 commits into from
Sep 20, 2022

Conversation

aapoalas
Copy link
Contributor

Upstream CL: https://chromium-review.googlesource.com/c/v8/v8/+/3844662

Fast API calls invalidly used plain v8::Value for the options.data representation. This effectively meant that only SMI data could successfully pass through to fast calls.

The issue has now been fixed upstream, meaning that the options.data representation has become v8::Local<v8::Value>. This PR should then unblock downstream PR denoland/deno#15527

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Because this is a fix, is there some test that could be added that failed before but now passes?

It seems the test-api.cc changes in the CL might provide a good test case.

@aapoalas
Copy link
Contributor Author

Yeah, the CL test would be a good case, or possibly v8::External usage as data as that will probably be the most utilized case for Deno.

I'm not too familiar with rusty_v8's testing structures though. I'll see if I can't figure something out.

@littledivy littledivy merged commit 2ba52ed into denoland:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants