fix: property_attribute operator
#1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* property_attribute previously had an addition operator overload which doesn't make much sense in comparison to the corresponding V8 enumeration. This changes that to a bitor overload. * There was an edge case where READ_ONLY (1) + READ_ONLY (1) + DONT_ENUM (2) would evaluate to DONT_DELETE (4) instead of READ_ONLY + DONT_ENUM because of addition. This change also fixes that and adds a test for that case. Signed-off-by: Darshan Sen <[email protected]>
bnoordhuis
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property_attributepreviously had an addition operator overload which doesn't make much sense in comparison to the corresponding V8 enumeration. This changes that to a bitor overload.There was an edge case where
READ_ONLY (1) + READ_ONLY (1) + DONT_ENUM (2)would evaluate toDONT_DELETE (4)instead ofREAD_ONLY + DONT_ENUMbecause of addition. This change also fixes that and adds a test for that case.Signed-off-by: Darshan Sen [email protected]
cc @bnoordhuis since this was added in #228