Fix creation of invalid librusty_v8.a #1059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building rusty_v8 for targets lacking a binary
librusty_v8.a
, for exampleaarch64-unknown-linux-musl
, currently fails with a confusing error message:This is because build.rs falls back to use of curl after
download_file.py
fails. The curl command is currently ignoring HTTP error statuses and writes the HTTP error message to librusty_v8.a:This PR adds curl's
-f
flag to the command arguments which results in a more useful error message, as well as not writing an invalidlibrusty_v8.a
.