Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of invalid librusty_v8.a #1059

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Fix creation of invalid librusty_v8.a #1059

merged 1 commit into from
Aug 26, 2022

Conversation

wg
Copy link
Contributor

@wg wg commented Aug 26, 2022

Building rusty_v8 for targets lacking a binary librusty_v8.a, for example aarch64-unknown-linux-musl, currently fails with a confusing error message:

error: failed to add native library $PWD/target/aarch64-unknown-linux-musl/debug/gn_out/obj/librusty_v8.a: file too small to be an archive

This is because build.rs falls back to use of curl after download_file.py fails. The curl command is currently ignoring HTTP error statuses and writes the HTTP error message to librusty_v8.a:

% cat $PWD/target/aarch64-unknown-linux-musl/debug/gn_out/obj/librusty_v8.a
Not Found

This PR adds curl's -f flag to the command arguments which results in a more useful error message, as well as not writing an invalid librusty_v8.a.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ry ry merged commit 746f7a3 into denoland:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants