Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose from_function_callback_info #1016

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Expose from_function_callback_info #1016

merged 6 commits into from
Jun 28, 2022

Conversation

littledivy
Copy link
Member

This commit makes FunctionCallbackArguments::from_function_callback_info
and ReturnValue::from_function_callback_info public API.

Currently, there is no way to use FunctionCallbackArguments
and ReturnValue from Function::builder_raw.

bartlomieju
bartlomieju reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exercise these APIs in test_api.rs

piscisaureus
piscisaureus reviewed Jun 27, 2022
View reviewed changes
src/function.rs Outdated Show resolved Hide resolved
@littledivy littledivy mentioned this pull request Jun 28, 2022
Closed
@littledivy littledivy merged commit 95f2ba3 into denoland:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@littledivy @piscisaureus @bartlomieju