Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about cURL #1111

Closed
Fabizocker456 opened this issue Oct 22, 2022 · 4 comments
Closed

Add note about cURL #1111

Fabizocker456 opened this issue Oct 22, 2022 · 4 comments

Comments

@Fabizocker456
Copy link

This crate cannot be installed without curl, it would be nice to add a notice to README.md and/or the crates.io to prevent others from wasting these 30 minutes like I just did.
@bartlomieju
Copy link
Member

Makes sense, PRs are very welcome!

gutenfries added a commit to gutenfries/rusty_v8 that referenced this issue Nov 3, 2022
@gutenfries
(docs): add note about curl [denoland#1111]
c2aa091
@gutenfries gutenfries mentioned this issue Nov 3, 2022
Merged
@gutenfries
Copy link
Contributor

@Fabizocker456, is this satisfactory?

@Fabizocker456
Copy link
Author

Thanks, that's perfect

bartlomieju pushed a commit that referenced this issue Nov 20, 2022
@gutenfries
(docs): add note about curl [#1111] (#1114)
601fed8
@bartlomieju
Copy link
Member

Done in #1111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bartlomieju @gutenfries @Fabizocker456