Skip to content

Commit

Permalink
Rolling to V8 10.5.218.1 (#1036)
Browse files Browse the repository at this point in the history
Co-authored-by: Bartek Iwańczuk <[email protected]>
  • Loading branch information
denobot and bartlomieju committed Jul 25, 2022
1 parent b178f1f commit 21a8d4a
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Rusty V8 Binding

V8 Version: 10.4.132.20
V8 Version: 10.5.218.1

[![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions)
[![crates](https://img.shields.io/crates/v/v8.svg)](https://crates.io/crates/v8)
Expand Down
2 changes: 1 addition & 1 deletion build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ fn rerun_if_changed(out_dir: &Path, maybe_env: Option<NinjaEnv>, target: &str) {
let deps = ninja_get_deps(out_dir, maybe_env, target);
for d in deps {
let p = out_dir.join(d);
assert!(p.exists());
assert!(p.exists(), "Path doesn't exist: {:?}", p);
println!("cargo:rerun-if-changed={}", p.display());
}
}
Expand Down
14 changes: 13 additions & 1 deletion tests/test_api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ fn setup() -> SetupGuard {
))
.is_ok());
v8::V8::set_flags_from_string(
"--expose_gc --harmony-import-assertions --harmony-shadow-realm --allow_natives_syntax --turbo_fast_api_calls",
"--no_freeze_flags_after_init --expose_gc --harmony-import-assertions --harmony-shadow-realm --allow_natives_syntax --turbo_fast_api_calls",
);
v8::V8::initialize_platform(
v8::new_default_platform(0, false).make_shared(),
Expand Down Expand Up @@ -5703,6 +5703,13 @@ fn wasm_streaming_callback() {

ws.finish();
assert!(!scope.has_pending_background_tasks());
assert!(global.get(scope, name).unwrap().is_null());

while v8::Platform::pump_message_loop(
&v8::V8::get_current_platform(),
scope,
false, // don't block if there are no tasks
) {}

// We did not set wasm resolve callback so V8 uses the default one that
// runs microtasks automatically.
Expand All @@ -5729,6 +5736,11 @@ fn wasm_streaming_callback() {
ws.abort(Some(exception));
// We did not set wasm resolve callback so V8 uses the default one that
// runs microtasks automatically.
while v8::Platform::pump_message_loop(
&v8::V8::get_current_platform(),
scope,
false, // don't block if there are no tasks
) {}
assert!(global.get(scope, name).unwrap().strict_equals(exception));
}

Expand Down
2 changes: 1 addition & 1 deletion v8
Submodule v8 updated 1668 files

0 comments on commit 21a8d4a

Please sign in to comment.