fix: kill zombie builds if they complete

src/dev/build.ts

@@ -52,4 +52,5 @@ export async function build(
  );
 
  await Promise.all(plugins.map((plugin) => plugin.buildEnd?.()));
+ return "Build complete.";
 }

src/dev/dev_command.ts

@@ -46,7 +46,10 @@ export async function dev(
  state.config.dev = false;
  state.loadSnapshot = false;
  state.build = true;
- await build(state);
+ const result = await build(state);
+ if (result === "Build complete.") {
+ Deno.exit();
+ }
  } else if (config) {
  const state = await getInternalFreshState(
  manifest,

tests/build_test.ts

@@ -1,5 +1,6 @@
 import * as path from "$std/path/mod.ts";
 import {
+ $,
  assert,
  assertEquals,
  assertNotMatch,
@@ -305,3 +306,13 @@ Deno.test("prefer static files from build dir", async () => {
  },
  );
 });
+
+Deno.test("zombie build ends", async (t) => {
+ const fixture = path.join(Deno.cwd(), "tests", "fixture_zombie_build");
+ const result = await $`deno run -A ${fixture}/dev.ts build`.captureCombined()
+ .timeout("30s").text();
+ assertStringIncludes(
+ result,
+ "The manifest has been generated for 1 routes and 1 islands.",
+ );
+});

tests/deps.ts

@@ -49,3 +49,4 @@ export * as JSONC from "https://deno.land/[email protected]/jsonc/mod.ts";
 export * as colors from "https://deno.land/[email protected]/fmt/colors.ts";
 export { STATUS_CODE } from "https://deno.land/[email protected]/http/status.ts";
 export { stripAnsiCode } from "https://deno.land/[email protected]/fmt/colors.ts";
+export { default as $ } from "https://deno.land/x/[email protected]/mod.ts";

tests/fixture_zombie_build/deno.json

@@ -0,0 +1,39 @@
+{
+ "lock": false,
+ "tasks": {
+ "check": "deno fmt --check && deno lint && deno check **/*.ts && deno check **/*.tsx",
+ "cli": "echo \"import '\\$fresh/src/dev/cli.ts'\" | deno run --unstable -A -",
+ "manifest": "deno task cli manifest $(pwd)",
+ "start": "deno run -A --watch=static/,routes/ dev.ts",
+ "build": "deno run -A dev.ts build",
+ "preview": "deno run -A main.ts",
+ "update": "deno run -A -r https://fresh.deno.dev/update ."
+ },
+ "lint": {
+ "rules": {
+ "tags": [
+ "fresh",
+ "recommended"
+ ]
+ }
+ },
+ "exclude": [
+ "**/_fresh/*"
+ ],
+ "imports": {
+ "$fresh/": "file:https:///Users/reed/code/denoland/fresh/",
+ "preact": "https://esm.sh/[email protected]",
+ "preact/": "https://esm.sh/[email protected]/",
+ "@preact/signals": "https://esm.sh/*@preact/[email protected]",
+ "@preact/signals-core": "https://esm.sh/*@preact/[email protected]",
+ "tailwindcss": "npm:[email protected]",
+ "tailwindcss/": "npm:/[email protected]/",
+ "tailwindcss/plugin": "npm:/[email protected]/plugin.js",
+ "$std/": "https://deno.land/[email protected]/"
+ },
+ "compilerOptions": {
+ "jsx": "react-jsx",
+ "jsxImportSource": "preact"
+ },
+ "nodeModulesDir": true
+}

tests/fixture_zombie_build/dev.ts

@@ -0,0 +1,8 @@
+#!/usr/bin/env -S deno run -A --watch=static/,routes/
+
+import dev from "$fresh/dev.ts";
+import config from "./fresh.config.ts";
+
+import "$std/dotenv/load.ts";
+
+await dev(import.meta.url, "./main.ts", config);

tests/fixture_zombie_build/fresh.config.ts

@@ -0,0 +1,6 @@
+import { defineConfig } from "$fresh/server.ts";
+import tailwind from "$fresh/plugins/tailwind.ts";
+
+export default defineConfig({
+ plugins: [tailwind()],
+});

tests/fixture_zombie_build/fresh.gen.ts

@@ -0,0 +1,19 @@
+// DO NOT EDIT. This file is generated by Fresh.
+// This file SHOULD be checked into source version control.
+// This file is automatically updated during development when running `dev.ts`.
+
+import * as $index from "./routes/index.tsx";
+import * as $Network from "./islands/Network.tsx";
+import { type Manifest } from "$fresh/server.ts";
+
+const manifest = {
+ routes: {
+ "./routes/index.tsx": $index,
+ },
+ islands: {
+ "./islands/Network.tsx": $Network,
+ },
+ baseUrl: import.meta.url,
+} satisfies Manifest;
+
+export default manifest;

tests/fixture_zombie_build/islands/Network.tsx

@@ -0,0 +1,29 @@
+import { useEffect, useRef } from "preact/hooks";
+import { Network } from "https://esm.sh/[email protected]/standalone";
+import { IS_BROWSER } from "$fresh/runtime.ts";
+
+export default function NetworkDiagram() {
+ const container = useRef<HTMLDivElement>(null);
+ const network = useRef<Network | null>(null);
+
+ const nodes = [{ id: 1, label: "Node 1" }, { id: 2, label: "Node 2" }];
+ const edges = [{ from: 1, to: 2 }];
+
+ useEffect(() => {
+ if (!container.current) return;
+ // this check isn't necessary because this doesn't run on the server regardless
+ // but this is the standard advice for not blocking the build, so i'll include it just to demonstrate
+ if (IS_BROWSER || !Deno.args.includes("build")) {
+ network.current = new Network(container.current, {
+ nodes: nodes,
+ edges: edges,
+ }, {});
+ }
+ }, []);
+
+ return (
+ <div class="m-4 p-4 border border-sky-500">
+ <div ref={container} />
+ </div>
+ );
+}

tests/fixture_zombie_build/main.ts

@@ -0,0 +1,13 @@
+/// <reference no-default-lib="true" />
+/// <reference lib="dom" />
+/// <reference lib="dom.iterable" />
+/// <reference lib="dom.asynciterable" />
+/// <reference lib="deno.ns" />
+
+import "$std/dotenv/load.ts";
+
+import { start } from "$fresh/server.ts";
+import manifest from "./fresh.gen.ts";
+import config from "./fresh.config.ts";
+
+await start(manifest, config);

tests/fixture_zombie_build/routes/index.tsx

@@ -0,0 +1,13 @@
+import { Head } from "$fresh/runtime.ts";
+import Network from "../islands/Network.tsx";
+
+export default function Home() {
+ return (
+ <>
+ <Head>
+ <link rel="stylesheet" href="styles.css" />
+ </Head>
+ <Network />
+ </>
+ );
+}

tests/fixture_zombie_build/static/styles.css

@@ -0,0 +1,3 @@
+@tailwind base;
+@tailwind components;
+@tailwind utilities;

tests/fixture_zombie_build/tailwind.config.ts

@@ -0,0 +1,7 @@
+import { type Config } from "tailwindcss";
+
+export default {
+ content: [
+ "{routes,islands,components}/**/*.{ts,tsx}",
+ ],
+} satisfies Config;