Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [toml] adapted to TOML's key encoding spec #612

Merged
merged 3 commits into from
Sep 23, 2019
Merged

fix: [toml] adapted to TOML's key encoding spec #612

merged 3 commits into from
Sep 23, 2019

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Sep 23, 2019

  • Dumper is emitting invalid TOML format.
  • Table names or keys should be wrapped with "" if title contains characters except A-Za-z0-9_-

@keroxp
Copy link
Contributor Author

keroxp commented Sep 23, 2019 •
edited

  • Parser should also be fixed. Quoted titles like ["https://deno.land"] can't be parsed properly.
  • This PR is ready

zekth
zekth approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM

ry
ry approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 54a5b95 into denoland:master Sep 23, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@keroxp @ry
fix TOML's key encoding (denoland/deno_std#612)
aa21e7b 
Original: denoland/deno_std@54a5b95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@zekth zekth zekth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keroxp @ry @zekth