fix: Use AssertionError in assertEqual #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ry should be landable |
ry
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
LGTM
@bartlomieju Can you draft a commit message? This is a bit more than using just AssertionError.
* merge 'testing/pretty.ts' into 'testing/asserts.ts' * throw AssertionError in assertEquals * update misc tests use AssertionError
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
* merge 'testing/pretty.ts' into 'testing/asserts.ts' * throw AssertionError in assertEquals * update misc tests use AssertionError Original: denoland/deno_std@ff2d7f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #555
I merged
testing/asserts.tsandtesting/pretty.ts- both files were short so there's really no need to split them.Note that this PR is blocked by #556