Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept absolute root directories in the file server #558

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Accept absolute root directories in the file server #558

merged 1 commit into from
Aug 15, 2019

Conversation

nayeemrmn
Copy link
Contributor

Closes #557.

Also some refactors:

  • path utility functions are used where appropriate.
  • I had some difficulty along the way with some variable names so I made them more consistent. A filePath/dirPath is an absolute FS path to a file or directory, whereas fileUrl/dirUrl is a syntactically absolute path but relative to the served root, consistent with req.url. The latter were confusingly called fileName/dirName before.

@nayeemrmn nayeemrmn force-pushed the file-server-abs-target branch 3 times, most recently from 7f126ac to e894e8e Compare August 9, 2019 17:06
ry
ry approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 262d957 into denoland:master Aug 15, 2019
@nayeemrmn nayeemrmn deleted the file-server-abs-target branch August 15, 2019 16:01
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@nayeemrmn @ry
Accept absolute root directories in the file server (denoland/deno_st…
47adc62 
…d#558)

Original: denoland/deno_std@262d957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Absolute root directory argument in the file server
3 participants
@nayeemrmn @ry @bartlomieju