Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http] fixing content-length checking #437

Merged
merged 2 commits into from
May 23, 2019
Merged

[http] fixing content-length checking #437

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af12b75
fixing content-length checking
zekth May 23, 2019
91dff38
add todo
zekth May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
add todo
  • Loading branch information
@zekth
zekth committed May 23, 2019
commit 91dff38fa99635b1c92970dada34ce04275d6a2b
4 changes: 4 additions & 0 deletions http/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,10 @@ export async function readRequest(
[req.method, req.url, req.proto] = firstLine.split(" ", 3);
[req.headers, err] = await tp.readMIMEHeader();
fixLength(req);
// TODO(zekth) : add parsing of headers eg:
// rfc: https://tools.ietf.org/html/rfc7230#section-3.3.2
// A sender MUST NOT send a Content-Length header field in any message
// that contains a Transfer-Encoding header field.
return [req, err];
}

Expand Down