[http] delete conn parameter in readRequest #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ry
added a commit
to ry/deno_std
that referenced
this pull request
May 23, 2019
This reverts commit 209183e.
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
To bring it inline with Go API Original: denoland/deno_std@209183e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #427
Also deleted
connproperty ofServerRequestbecause it's not used anymore and it's not in the request struct of golang:https://github.com/golang/go/blob/1d1ba85d9986bb56226046c06dec4ce63ef9fe48/src/net/http/request.go#L107