[bytes] fix bytesFindIndex and bytesFindLastIndex #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
deno --allow-read --allow-write prettier/main.ts --ignore node_modules --ignore testdata --ignore vendor
ry
reviewed
May 6, 2019
This reverts commit fe9d5b4.
arcatdmz
added a commit
to arcatdmz/danoweb
that referenced
this pull request
May 7, 2019
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
bytesFindIndexandbytesFindLastIndexindeno_std/bytescannot find the binary pattern when its occurrence has an overlap with a partly (but not completely) matching sequence.00101bytesFindIndexresult:1bytesFindIndexresult:-1Reproduction
Existing test cases are edited to reproduce the bug: arcatdmz@fe9d5b4
Two corresponding tests fail accordingly: https://gist.github.com/arcatdmz/08ae107dd5e29e2aaebf18e1d8b76d43
Fix
This pull request contains a commit that fixes the bug: arcatdmz@1251423
Context
multipart/form-dataposted by a web browser client.deno_std/multipart.https://gist.github.com/arcatdmz/307800328cd7aaa35e027cebab4a611a
sample.txtas shown in arcatdmz@c3ed68f, test failures are gone, and I notice it's a bug not indeno_std/multipartbut indeno_std/bytes.