fix: typo in parse_media_type.ts example #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lino-levan
approved these changes
Aug 7, 2023
Thanks. I signed it, but noticed it wasn't updating to reflect that, even after I clicked the recheck link in their comment. I'll try signing it again |
|
There we go, it's showing up as signed now 😅 |
|
Also thanks @lino-levan for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
parseMediaTypeexample fromstd/media_types/parse_media_type.ts, the example code asserts (erroneously) that an input oftext/html; charset=utf-8will return["application/json", { charset: "utf-8" }].This has been corrected to
["text/html", { charset: "utf-8" }].Thanks!