feat(regexp): add escape function #3334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3330
Escaping is fairly conservative to account for context sensitivity and forward compatibility with the
v
flag — the only non-alphanumeric printable ASCIIS that aren't escaped are"'_
, and of the characters that are escaped, almost half use the most conservative\x
hex notation. That could be reduced a little (but not much) by ignoring characters inClassSetReservedDoublePunctuator
, which only need escaping if repeated adjacent to each other in a within a character class in av
-flagged regex.