Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prettier): output to stdout instead of write file by default unless specified --write flag #332

Merged
merged 14 commits into from
May 21, 2019
Merged

feat(prettier): output to stdout instead of write file by default unless specified --write flag #332

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d7be465
feat: add --write flags to enable write file. default print to stdout
axetroy Apr 10, 2019
4d760a9
update format script
axetroy Apr 10, 2019
1dfb91c
fix: add --write flags for testcase
axetroy Apr 10, 2019
ad907e1
add test case for output to stdout
axetroy Apr 10, 2019
5f770f7
format the code
axetroy Apr 10, 2019
e12182c
fix test
axetroy Apr 10, 2019
868b5f3
fix end of line for testcase
axetroy Apr 11, 2019
b7612bc
Merge branch 'master' into prettier_print
axetroy Apr 15, 2019
2a5d317
merge master
axetroy May 16, 2019
31fcb06
Merge branch 'prettier_print' of https://github.com/axetroy/deno_std …
axetroy May 16, 2019
2579b95
fix eslint
axetroy May 16, 2019
964a787
always print formatted code to stdout if no --write flag
axetroy May 21, 2019
1829082
add help message for --write flag
axetroy May 21, 2019
d069d90
update help message
axetroy May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fix end of line for testcase
  • Loading branch information
@axetroy
axetroy committed Apr 11, 2019
commit 868b5f320525b93c5ca88cd3f2f512901af92400
7 changes: 4 additions & 3 deletions prettier/main_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
import { join } from "../fs/path.ts";
import { EOL } from "../fs/path/constants.ts";
import { assertEquals } from "../testing/asserts.ts";
import { test } from "../testing/mod.ts";
import { xrun } from "./util.ts";
Expand Down Expand Up @@ -217,13 +218,13 @@ test(async function testPrettierPrintToStdout() {

const { stdout } = await run([...cmd, file0]);
// the source file will not change without `--write` flags
assertEquals(await getSourceCode(file0), "console.log (0)\r\n");
assertEquals(await getSourceCode(file0), "console.log (0)" + EOL);
// the output will be formatted code
assertEquals(stdout, "console.log(0);\r\n");
assertEquals(stdout, "console.log(0);" + EOL);

const { stdout: formattedCode } = await run([...cmd, file1]);
// the source file will not change without `--write` flags
assertEquals(await getSourceCode(file1), "console.log(0);\r\n");
assertEquals(await getSourceCode(file1), "console.log(0);" + EOL);
// the output will be empty string. because the formatted content is same with before
assertEquals(formattedCode, "");

Expand Down