perf(http): optimize file server #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+196
to
+208
| // The fnv-1a hash function. | ||
| function fnv1a(buf: string): string { | ||
| let hash = 2166136261; // 32-bit FNV offset basis | ||
| for (let i = 0; i < buf.length; i++) { | ||
| hash ^= buf.charCodeAt(i); | ||
| // Equivalent to `hash *= 16777619` without using BigInt | ||
| // 32-bit FNV prime | ||
| hash += (hash << 1) + (hash << 4) + (hash << 7) + (hash << 8) + | ||
| (hash << 24); | ||
| } | ||
| // 32-bit hex string | ||
| return (hash >>> 0).toString(16); | ||
| } |
There was a problem hiding this comment.
Is this not available is std/crypto?
Comment on lines
-100
to
+102
| diffMessages.push(c(`${createSign(result.type)}${line}`)); | ||
| diffMessages.push(c(`${ | ||
| createSign(result.type) | ||
| }${line}`)); |
There was a problem hiding this comment.
I've seen this change recently in some other PR, seems to be related to dprint. CC @dsherret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2107
Major changes:
Deno.File#readableinstead of a wrapper stream. See perf(http): optimizeReadableStreams backed by a resource deno#14284faster hex function for out of other algorithms (likesha-1), using hex lookup table.--quietflag with--verbose. Public API remains unchanged.use simpler extname extraction to avoid scanning manually. (downsides?)Benchmarks:
main:This patch: