Chore: sort rules alphabetically #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also checked the rules in README and found there are missing rules and two rules have different codes from the original ESLint's rules. I have fixed them as well. |
bartlomieju
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_recommended_rulesandget_all_rulesgive us the provided rules, but currently their orders are not sorted alphabetically.It would be better for them to be sorted, because Deno is going to use
get_recommended_rulesby denoland/deno#7222 and then the rules returned by it will be displayed in the same order when runningdeno lint --unstable --rules.So in this PR, I put them in sorted order.
Besides, I added tests to make sure the rules are sorted alphabetically, which will help us detect unordered rules in future patches.