Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support wildcards in npm workspaces #74

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 7, 2024

Closes #67

package_json_url: pkg_json.specifier(),
source: err,
}
})?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is exactly correct, but should be good enough for a first pass.

@dsherret dsherret marked this pull request as ready for review July 8, 2024 14:37
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit c962f68 into denoland:main Jul 8, 2024
3 checks passed
@dsherret dsherret deleted the feat_npm_workspace_wildcards branch July 8, 2024 17:30
dsherret added a commit to denoland/deno that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for wildcards in npm workspaces
2 participants