perf(serde_v8): drop need for EscapableHandleScope #9990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another improvement to
serde_v8
's serialization code, it drops the need for creating av8::EscapableHandleScope
or "subscope". It's a simplication and optimization similar in nature to #9987.This is very exciting since sub 100ns/op for sync-ops appears to be within reach ! (at least on my machine, M1 Air)
Benches
Using our trusty
op_baseline
bench to compare withmain
:(Note that the before and after of these benches integrates changes from #9983)