Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch op_now to be a json-op #9974

Merged
merged 4 commits into from
Apr 3, 2021
Merged

Switch op_now to be a json-op #9974

merged 4 commits into from
Apr 3, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 2, 2021

Making it 20% faster and simpler.

Benches

Comparing performance.now() (calling op_now) in the deno_common bench:

v1.8.2:
perf_now:                n = 500000, dt = 0.700s, r = 714286/s, t = 1400ns/op
Main:
perf_now:                n = 500000, dt = 0.403s, r = 1240695/s, t = 806ns/op
This PR:
perf_now:                n = 500000, dt = 0.331s, r = 1510574/s, t = 662ns/op

bartlomieju
bartlomieju approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 824bd2f into denoland:main Apr 3, 2021
@AaronO AaronO deleted the ops/json-op-now branch April 3, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AaronO @bartlomieju