Inject typescript version from package.json during build through env! (deno -v)
#997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, for some reason Windows build is complaining that Okay, its unicode issue... |
kevinkassimo
force-pushed
the
inject/ts-version
branch
2 times, most recently
from
93b343e
to
f69d5ca
Compare
kevinkassimo
force-pushed
the
inject/ts-version
branch
from
f69d5ca
to
befd0f7
Compare
ry
requested changes
Oct 16, 2018
| @@ -18,6 +19,10 @@ | |||
| sys.exit(1) | |||
| ninja_args = ["-C", build_path()] + ninja_args | |||
|
|
|||
| package_json_env = { | |||
| "TYPESCRIPT_VERSION": package_json.get_typescript_version() | |||
| } | |||
There was a problem hiding this comment.
I don’t like that this depends on special behavior in build.py.
Ideally people would be able to build deno using gn and ninja - build.py is just to make things more ergonomic.
The way I was imagining this done was to print the versions from JS. The V8 version and Deno version can be passed in the Start message.
|
closed in favor of #995 - but thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #993
Instead of adding new bindings to v8 or change
msg.Startformats (which requires us to runisolate.execute("deno_main.js", "denoMain();")), we should be able to inject the version during compilation frompackage.jsonenv!()macro expands at compile time.(Other python file changes are caused by
./tools/format.py)