chore(cli): Add "Deno" to the windows file description. #9959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Apr 1, 2021
| @@ -101,4 +101,4 @@ nix = "0.20.0" | |||
| OriginalFilename = "deno.exe" | |||
| LegalCopyright = "© Deno contributors & Deno Land Inc. MIT licensed." | |||
| ProductName = "Deno" | |||
| FileDescription = "A secure runtime for JavaScript and TypeScript." | |||
| FileDescription = "Deno: A secure runtime for JavaScript and TypeScript" | |||
There was a problem hiding this comment.
Removed period because nothing else in my task manager has a period.
Also, used a colon because it's similar to what node.js does:
dsherret
commented
Apr 1, 2021
| @@ -101,4 +101,4 @@ nix = "0.20.0" | |||
| OriginalFilename = "deno.exe" | |||
| LegalCopyright = "© Deno contributors & Deno Land Inc. MIT licensed." | |||
| ProductName = "Deno" | |||
| FileDescription = "A secure runtime for JavaScript and TypeScript." | |||
| FileDescription = "Deno: A secure runtime for JavaScript and TypeScript" | |||
There was a problem hiding this comment.
FWIW, main website says "A secure runtime for JavaScript and TypeScript." while the repo description says "A secure JavaScript and TypeScript runtime.". I kept this matching the website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened task manager and noticed the Deno process does not say "Deno" in the description.
You can also see Deno is not visible in the screenshots on this previous PR in another scenario: #6881