Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/dts): fix futime and futime example #9953

Merged
merged 1 commit into from
Apr 1, 2021
Merged

fix(cli/dts): fix futime and futime example #9953

merged 1 commit into from
Apr 1, 2021

Conversation

majidsajadi
Copy link
Contributor

I was working on deno_std and I saw an example for futime and futimeSync. as far as I know Deno.openSync needs write option alongside with create/append option. so I updated the example. let me know if I'm wrong.

ref:

deno/cli/dts/lib.deno.ns.d.ts

Line 812 in d6d5ced

create?: boolean;

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kt3k
kt3k approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@majidsajadi Can you sign the CLA from the above link?

@majidsajadi
Copy link
Contributor Author

@kt3k done.

@kitsonk kitsonk merged commit 2d7fdb0 into denoland:main Apr 1, 2021
kitsonk pushed a commit that referenced this pull request Apr 1, 2021
@majidsajadi @kitsonk
chore(cli): fix futime and futimeSync code examples (#9953)
1f448e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@majidsajadi @CLAassistant @kt3k @kitsonk