Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the
serde_v8
benches from the original repo, usingbencher
likecore/benches/op_baseline
.Notes
The original benches were compared to
serde_json
working on existing strings. Whilst useful, these_json
benches can be misleading and lead people to believe thatserde_v8
is slower than using JSON for the op-layer, forgetting that using JSON requires the extra steps ofJSON.parse()/.stringify()
and co, not measured here.Since they can't be meaningfully compared in absolute, it might make sense to remove them
Output