Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): decode JsStackFrames using serde_v8 #9902

Merged
merged 5 commits into from
Mar 27, 2021
Merged

refactor(core): decode JsStackFrames using serde_v8 #9902

merged 5 commits into from
Mar 27, 2021

Commits on Mar 26, 2021

  1. core/error: decode JsStackFrames using serde_v8

    @AaronO
    AaronO committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ddd7a86 View commit details
    Browse the repository at this point in the history

  2. JsStackFrame: use serde camelCase

    @AaronO
    AaronO committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    10505a3 View commit details
    Browse the repository at this point in the history

  3. Use serde rename to fix inconsistent case of JsStackFrame's isToplevel

    @AaronO
    AaronO committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    8352f3b View commit details
    Browse the repository at this point in the history

  4. restore filter of non-array values for error.__callSiteEvals

    @AaronO
    AaronO committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    268cc75 View commit details
    Browse the repository at this point in the history

  5. core: handle NativeJsError.stack as before since it's "special" 

    Its v8::Object::get returns None sometimes (not undefined), which isn't expected.

Might be able to handle this better in the future, but for now it's better to panic than to swallow the value
    @AaronO
    AaronO committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ad8915a View commit details
    Browse the repository at this point in the history