Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typescript warning #99

Merged
merged 2 commits into from
Jun 4, 2018
Merged

fix typescript warning #99

merged 2 commits into from
Jun 4, 2018

Conversation

ztplz
Copy link
Contributor

@ztplz ztplz commented Jun 2, 2018

[ts] Return type of exported function has or is using private name 'AmdDefine'.

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

qti3e
qti3e approved these changes Jun 2, 2018
View reviewed changes
Copy link
Contributor

@qti3e qti3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you...

@ry ry merged commit 37dd416 into denoland:master Jun 4, 2018
@ry
Copy link
Member

ry commented Jun 4, 2018

Thanks.

@trusktr
Copy link

trusktr commented Dec 21, 2019

The exports should not be required to make things work, because it changes the exposed API which may be something undesirable in some cases.

I've opened a request to fix issues like these in TypeScript by bringing declaration files to parity with language features. microsoft/TypeScript#35822

humancalico pushed a commit to humancalico/deno that referenced this pull request Aug 24, 2020
@bartlomieju
refactor: add deny clause (denoland#99)
9a9af34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qti3e qti3e qti3e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ztplz @CLAassistant @ry @trusktr @qti3e