refactor(lsp): remove unused code #9897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the
assetfield ofStatebecause it seems to be unused.Taking a glance at the commit history, this field was introduced in #8771, and at that time the field value was used in the
request_assetfunction.After that, in #8727, both
request_assetand invokingop_set_assetfrom JS were removed:request_assetwas removedop_set_assetwas removedSo since then, the
assetfield ofStatestruct has seemed to be unused. I wonder why "unused" warning didn't emerge at that time though. (#[allow(unused)]was added today in #9895)