Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime/permissions): Rename permission structs #9841

Merged
merged 3 commits into from
Mar 21, 2021

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Mar 20, 2021

  • BooleanPermission -> UnitPermission: Since it's not boolean. UnaryPermission queries with one argument, UnitPermission queries with 0 and is only associated with a single PermissionState.
  • {Read,Write,Net}Permission -> {Read,Write,Net}Descriptor: UnaryPermission<ReadDescriptor> doesn't stutter, more accurate.

Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit dd12a66 into denoland:main Mar 21, 2021
@nayeemrmn nayeemrmn deleted the rename-permission-structs branch March 21, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants