Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Adds type errors to invalid arguments for print #9834

Merged
merged 2 commits into from
Mar 21, 2021

Conversation

mitch292
Copy link
Contributor

@mitch292 mitch292 commented Mar 19, 2021

Resolves #9812 .

Will now throw type error when too many arguments are passed or the second argument can't be parsed into an integer. Had some trouble figuring out how to test the core changes. Would be great to get some direction if possible and a test is required.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@ry ry merged commit c00872c into denoland:main Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to make embedding deno_runtime's code safe from assert carsh?
2 participants