feat(permissions): allow run permission to take values #9833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypt096
approved these changes
Mar 19, 2021
# Conflicts: # runtime/ops/worker_host.rs
# Conflicts: # runtime/ops/worker_host.rs # runtime/permissions.rs
bartlomieju
reviewed
Mar 24, 2021
cli/flags.rs
Outdated
| if let Some(run_wl) = matches.values_of("allow-run") { | ||
| let run_allowlist: Vec<String> = run_wl.map(ToString::to_string).collect(); | ||
| flags.allow_run = Some(run_allowlist); | ||
| debug!("env allowlist: {:#?}", &flags.allow_run); |
| .min_values(0) | ||
| .takes_value(true) | ||
| .use_delimiter(true) | ||
| .require_equals(true) |
There was a problem hiding this comment.
I think some kind of validator is needed here, similar to --allow-env PR
There was a problem hiding this comment.
sure, but how would we validate passed commands? check if they actually exist? That would be somewhat weird, as we don't chck if a path exists for the path related permissions
|
@crowlKats this PR looks good to me, let's land it for 1.9. Please rebase |
# Conflicts: # runtime/ops/process.rs
bartlomieju
reviewed
Apr 8, 2021
There was a problem hiding this comment.
@crowlKats before landing can you add an integration test to cli/tests/integration_tests.rs that uses an allow list? Something like _045_proxy that runs Deno executable.
bartlomieju
reviewed
Apr 9, 2021
bartlomieju
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9925