Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): ensure single line functions don't yield false positives #9717

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Mar 7, 2021

Fixes #9589

@caspervonb caspervonb force-pushed the fix-coverage-correct-single-line-false-positive branch from fdc69a6 to 4d3c5ff Compare March 7, 2021 18:12
@caspervonb
Copy link
Contributor Author

Some duplication here; I have a terse reporter patch coming up that cleans up a bit so I'll leave the duplication alone for now.

@caspervonb caspervonb force-pushed the fix-coverage-correct-single-line-false-positive branch from 4d3c5ff to a51603b Compare March 7, 2021 18:31
@caspervonb caspervonb force-pushed the fix-coverage-correct-single-line-false-positive branch from a51603b to 1d72cde Compare March 7, 2021 21:22
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Casper

@lucacasonato lucacasonato merged commit 3ec9a9b into denoland:main Mar 8, 2021
@caspervonb caspervonb deleted the fix-coverage-correct-single-line-false-positive branch March 8, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage ratio is inconsistent
2 participants