Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/ast): Pass importsNotUsedAsValues to swc #9714

Merged
merged 2 commits into from
Mar 7, 2021
Merged

fix(cli/ast): Pass importsNotUsedAsValues to swc #9714

merged 2 commits into from
Mar 7, 2021

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #9709.

@ry ry requested a review from kitsonk March 7, 2021 13:49
kitsonk
kitsonk approved these changes Mar 7, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot!

@kitsonk kitsonk merged commit 33eea04 into denoland:main Mar 7, 2021
@nayeemrmn nayeemrmn deleted the swc-imports-not-used-as-values branch March 7, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno bundle should respect compiler option importsNotUsedAsValues: "preserve"
2 participants
@nayeemrmn @kitsonk