Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable sccache #9670

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Re-enable sccache #9670

merged 5 commits into from
Mar 3, 2021

Conversation

ry
Copy link
Member

@ry ry commented Mar 3, 2021 •
edited
Loading

runner before after after2
test_release macos-10.15 41m 34s 30m 49s 25m 47s
test_release windows-2019 55m 34s 33m 21s 37m 57s
bench ubuntu-latest-xl 20m 49s 20m 35s 20m 25s
lint ubuntu-latest 11m 40s 4m 20s 4m 24s
test_debug ubuntu-latest 36m 56s 34m 37s 32m 42s
test_release ubuntu-18.04 35m 50s FAIL 35m 50s

@ry ry mentioned this pull request Mar 3, 2021
Closed
@ry ry requested a review from piscisaureus March 3, 2021 18:04
piscisaureus
piscisaureus approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that our current LTO settings push the majority of the compute load to the link phase, which is why this patch has only a modest impact on build times.

@ry ry merged commit af7e021 into main Mar 3, 2021
@ry ry deleted the sccache-again branch March 3, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @piscisaureus