Pin lspower, because it made semver incompatible patch release #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hvithrafn In the future please don't update lsp-types a minor release in a lspower patch release. lsp-types is part of the lspower public interface so if that has a minor release (pre 1.x breaking change), then lspower must bump at minimum a minor too. The lsp-types update between [email protected] and [email protected] broke our 1.8.0 release. Thanks :-) |
This comment has been minimized.
This comment has been minimized.
|
Oops. Sorry. 🙏 |
kitsonk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.