Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime/web_worker): Don't block self.onmessage with TLA #9619

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Feb 27, 2021

Fixes #8735.
Fixes #9643.
Closes #8863.

cc @bartlomieju

This is #8863 with the test rewritten to not use worker.terminate(), not blocked by an unrelated bug.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nayeem

@bartlomieju bartlomieju merged commit 0f21213 into denoland:main Mar 4, 2021
@soootaleb
Copy link

That's awesome guys, I can't wait to upgrade my runtime. Do you know if this is going to be released with 1.8.1 ?

@bartlomieju
Copy link
Member

That's awesome guys, I can't wait to upgrade my runtime. Do you know if this is going to be released with 1.8.1 ?

Yes, it will be

@nayeemrmn nayeemrmn deleted the worker-tla branch March 7, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector blocked during top-level await Workers & top-level-await changed behavior between 1.4.6 and 1.6.0
3 participants