Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reafactor(lsp): use generics with JSON values #9587

Merged
merged 2 commits into from
Feb 25, 2021
Merged

reafactor(lsp): use generics with JSON values #9587

merged 2 commits into from
Feb 25, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 23, 2021

This uses generics to serialize and deserialize values better in the LSP.

lucacasonato
lucacasonato approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kitsonk kitsonk merged commit 90e4c5d into denoland:main Feb 25, 2021
@kitsonk kitsonk deleted the reaf_lsp_json_generics branch February 25, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kitsonk @lucacasonato @bartlomieju