fix(lsp): diagnostics use own thread and debounce #9572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will incorporate some concepts here in future PRs. |
kitsonk
force-pushed
the
fix-lsp-debounce
branch
from
7f890be
to
43a09db
Compare
|
Based on a chat we had a core team yesterday, I am re-opening this PR as it might be a viable approach... Benchmarking on my local machine demonstrates that it does the "big" benchmark in ~2800ms where as current main does it in ~7563ms and the combined #9552 and #9557 results in ~5049ms. So this PR at the moment gives the biggest improvement in performance, but without changing the locking mechanisms. |
|
Looking at the Bench CI, it is producing a 3178ms benchmark, while main is producing around ~8600ms. |
piscisaureus
reviewed
Mar 1, 2021
piscisaureus
reviewed
Mar 1, 2021
kitsonk
force-pushed
the
fix-lsp-debounce
branch
from
43a09db
to
c72b45b
Compare
bnoordhuis
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.