Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Reduce verbosity of binding core functions #9497

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Feb 14, 2021

Removes boilerplate in bindings::initialize_context() when setting core functions, improving readability.

initialize_context() is shortened from 98 to 36 lines, making the core logic easier to grasp.

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2021

CLA assistant check
All committers have signed the CLA.

@AaronO
Copy link
Contributor Author

AaronO commented Feb 14, 2021

Slightly longer after rustfmt expanded the setMacrotaskCallback line, but point still stands.

On that note, should 80 still be the max-width ? I know the linux kernel recently relaxed their max-width to 100, might be worth considering (but it's minor at the end of the day, no point bikeshedding)

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AaronO

@bartlomieju bartlomieju merged commit 1afe6b4 into denoland:master Feb 15, 2021
@AaronO AaronO deleted the refactor/bindings_verbosity branch February 15, 2021 12:32
@AaronO AaronO restored the refactor/bindings_verbosity branch February 15, 2021 12:33
@AaronO AaronO deleted the refactor/bindings_verbosity branch February 15, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants