Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): handle code lenses for non-documents #9454

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 9, 2021

This PR fixes two issues which were causing code lenses for assets and cached dependencies to not be properly handled. The first bug was that tsc NavigationTrees were not being calculated and the second was that the code lens resolution was not formatting the URL properly to be consumed by an lsp client.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit d95666c into denoland:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants