Check thrown type, print String(...) if not instance of error #939

kevinkassimo · 2018-10-08T04:05:03Z

Trying to close #935

Only print stack if the thrown is of instance of Error. Otherwise, print Thrown: ${String(thrown)}.
For example,

throw {};

now prints

Thrown: [object Object]

ry

LGTM - thanks Kevin

(My only concern is adding new "check_output_tests" as they take longer to run. But in this case it's probably good to have an integration tests. Please try to use unit_tests instead of "check_output_tests" where possible.)

Check thrown type; Print toString() if not instance of error

d8185b0

kevinkassimo changed the title ~~Check thrown type, print toString() if not instance of error~~ [WIP] Check thrown type, print toString() if not instance of error Oct 8, 2018

Use String(...)

324c4c6

kevinkassimo changed the title ~~[WIP] Check thrown type, print toString() if not instance of error~~ Check thrown type, print toString() if not instance of error Oct 8, 2018

kevinkassimo changed the title ~~Check thrown type, print toString() if not instance of error~~ Check thrown type, print String(...) if not instance of error Oct 8, 2018

ry approved these changes Oct 8, 2018

View reviewed changes

ry merged commit 2b8cee9 into denoland:master Oct 8, 2018

kevinkassimo deleted the error/check-type branch December 27, 2019 07:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check thrown type, print String(...) if not instance of error #939

Check thrown type, print String(...) if not instance of error #939

kevinkassimo commented Oct 8, 2018 •

edited

Loading

ry left a comment

Check thrown type, print String(...) if not instance of error #939

Check thrown type, print String(...) if not instance of error #939

Conversation

kevinkassimo commented Oct 8, 2018 • edited Loading

ry left a comment

Choose a reason for hiding this comment

kevinkassimo commented Oct 8, 2018 •

edited

Loading